Fix ES818BinaryQuantizedVectorsReader to not use directIO during merge #130114
+65
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes the BBQ reader to **not** use directIO when merging the original float vectors.
Collaborator
|
Pinging @elastic/es-search-relevance (Team:Search Relevance) |
elasticsearchmachine
added
the
Team:Search Relevance
Collaborator
|
Hi @jimczi, I've created a changelog YAML for you. |
thecoop
approved these changes
Jun 26, 2025
Member
thecoop
left a comment
thecoop
left a comment
There was a problem hiding this comment.
Good spot. We could probably get this in for 9.1.0... Up to you
jimczi
added
auto-backport
ChrisHegarty
approved these changes
Jun 26, 2025
jimczi
added a commit
to jimczi/elasticsearch
that referenced
this pull request
Jun 27, 2025
elastic#130114) This commit fixes the BBQ reader to **not** use directIO when merging the original float vectors.
Collaborator
💚 Backport successful
|
mridula-s109
pushed a commit
to mridula-s109/elasticsearch
that referenced
this pull request
Jul 3, 2025
elastic#130114) This commit fixes the BBQ reader to **not** use directIO when merging the original float vectors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes the BBQ reader to not use directIO when merging the original float vectors.